Updating .travis.yml and package.json to require node 0.10 or newer #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versions of grunt specified in package.json do not run on node 0.8. Grunt and its cohorts aren't required for the package itself or the test cases, so .travis.yml will remove them from package.json prior to installing dependencies and running tests.
|
Is anyone using Node 08 these days? I think I'd actually drop 0.8 support/testing, but someone from Slack should probably make that choice. |
|
We're ok with dropping it! |
|
Updated Travis build at https://travis-ci.org/jtatum/node-slack-client/builds/51156823 |
jtatum
changed the title
evansolomon
added a commit
that referenced
this pull request
Feb 18, 2015
Updating .travis.yml and package.json to require node 0.10 or newer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versions of grunt specified in package.json do not run on node 0.8. Grunt and its cohorts aren't required for the package itself or the test cases, so .travis.yml will remove them from package.json prior to installing dependencies and running tests.
Successful Travis build: https://travis-ci.org/jtatum/node-slack-client/builds/51145556